rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Franklin" <mfrank...@apache.org>
Subject Re: Review Request: RAVE-848 bug fix
Date Wed, 05 Dec 2012 22:05:30 GMT


> On Dec. 5, 2012, 2:09 p.m., Matt Franklin wrote:
> > I don't see a patch file for this.  Did you publish it?

Something is still not right.  I can't see/comment on the diff. 


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8317/#review14049
-----------------------------------------------------------


On Dec. 5, 2012, 2:39 p.m., Aaron Gooch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8317/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2012, 2:39 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> This is a small change to the person controller. I have added the proper response code
of 404 for user not found and added a logging statement in the event there was an unexpected
exception thrown (I believe the expectation was the user was null).
> 
> 
> This addresses bug RAVE-848.
>     https://issues.apache.org/jira/browse/RAVE-848
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviews.apache.org/r/8317/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aaron Gooch
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message