rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Gooch" <eodgo...@gmail.com>
Subject Re: Review Request: RAVE-848 bug fix
Date Tue, 11 Dec 2012 16:21:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8317/
-----------------------------------------------------------

(Updated Dec. 11, 2012, 4:21 p.m.)


Review request for rave.


Changes
-------

updated patch file - did not implement spring view resolvers. Doing so seems to be a larger
task than handling these error cases. We should update the entire application to use the HandlerExceptionResolver.


Description
-------

This is a small change to the person controller. I have added the proper response code of
404 for user not found and added a logging statement in the event there was an unexpected
exception thrown (I believe the expectation was the user was null).


This addresses bug RAVE-848.
    https://issues.apache.org/jira/browse/RAVE-848


Diffs (updated)
-----

  trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java
1420238 
  trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java
1420238 

Diff: https://reviews.apache.org/r/8317/diff/


Testing
-------


Thanks,

Aaron Gooch


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message