rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jack Weaver (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (RAVE-870) Canvas "sneeze guard" doesn't cover whole screen
Date Tue, 15 Jan 2013 08:18:12 GMT

    [ https://issues.apache.org/jira/browse/RAVE-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553585#comment-13553585
] 

Jack Weaver commented on RAVE-870:
----------------------------------

I believe I have a fix for this now (been working on it a bit yesterday, and tonight, since
I can't sleep quite yet).  I tried assigning the ticket to myself but I couldn't, so hopefully
no one else beat me to the punch.

This is my first time contributing to Apache (just sent my iCLA last Saturday, and got the
'acceptance letter' today!   =D) so go easy on me if I made a mistake.

I tested in FF & Chrome, and this seems to work.  The initial fix I attempted (setting
the size of the "sneeze guard" in rave.js:addCanvasOverlay()) didn't work, since the body/page
height can change if the widget being maximized can affect the height of the body when it
is maximized (I know that sounds confusing, but it's the best way I can think of to describe
when a maximized widget is removed from the "stack" of widgets, and thus affects the height
of the body).

Anyway, I'll attach "Rave-870.patch", and I am going to open up a review ticket now in the
ASF review system.

Thanks
                
> Canvas "sneeze guard" doesn't cover whole screen
> ------------------------------------------------
>
>                 Key: RAVE-870
>                 URL: https://issues.apache.org/jira/browse/RAVE-870
>             Project: Rave
>          Issue Type: Bug
>    Affects Versions: 0.19
>            Reporter: Chris Geer
>         Attachments: after.jpg, before.jpg
>
>
> When a gadget is maximized on a long page the "sneeze guard" doesn't cover the whole
screen.
> This can be reproduced using the default canonical login (on the mongo profile at least).
Load the default screen then scroll down to the bottom and put the bottom gadget into canvas
mode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message