rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Franklin" <mfrank...@apache.org>
Subject Re: Review Request: Require JS Patch
Date Thu, 20 Jun 2013 21:08:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12009/#review22179
-----------------------------------------------------------


In general, please try to ensure that the patch removes commented code and any autogenerated
headers.  Also note that new files need the proper apache license header.


/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/error.jsp
<https://reviews.apache.org/r/12009/#comment45583>

    why the .jsp?



/trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag
<https://reviews.apache.org/r/12009/#comment45584>

    If this is not being used anymore, it should be removed



/trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/third_party_js.tag
<https://reviews.apache.org/r/12009/#comment45586>

    shouldn't these scripts be pulled in by require now?



/trunk/rave-portal-resources/src/main/webapp/static/script/app.js
<https://reviews.apache.org/r/12009/#comment45585>

    Please remove usernames & autogenerated comments



/trunk/rave-portal-resources/src/main/webapp/static/script/core/rave_ajax.js
<https://reviews.apache.org/r/12009/#comment45587>

    Code that is no longer used should be removed, not commented out



/trunk/rave-portal-resources/src/main/webapp/static/script/core/rave_core.js
<https://reviews.apache.org/r/12009/#comment45588>

    Why was this removed?



/trunk/rave-portal-resources/src/main/webapp/static/script/core/rave_core.js
<https://reviews.apache.org/r/12009/#comment45598>

    this should be fine so long as rave is a reference to the same object as exports in the
end.
    
    Please remove comments before reposting patch



/trunk/rave-portal-resources/src/main/webapp/static/script/core/rave_core.js
<https://reviews.apache.org/r/12009/#comment45599>

    Remove commented code



/trunk/rave-portal-resources/src/main/webapp/static/script/core/rave_providers.js
<https://reviews.apache.org/r/12009/#comment45600>

    Autogenerated comments
    



/trunk/rave-portal-resources/src/main/webapp/static/script/core/rave_view_manager.js
<https://reviews.apache.org/r/12009/#comment45601>

    Autogenerated comments
    



/trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_event_bindings.js
<https://reviews.apache.org/r/12009/#comment45602>

    This feels a bit clumsy to me.  It seems that we should be defining event bindings generically
in the UI script that manages the function, rather than in this manner.



/trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_portal.js
<https://reviews.apache.org/r/12009/#comment45603>

    Is there something that replaces this?



/trunk/rave-portal/pom.xml
<https://reviews.apache.org/r/12009/#comment45571>

    This is an internal proxy configuration.  Please remove.


- Matt Franklin


On June 20, 2013, 5:01 p.m., Daniel Gornstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12009/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 5:01 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> First patch for requireJS
> 
> 
> Diffs
> -----
> 
>   /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/MessageBundleController.java
1495103 
>   /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/RegionWidgetTag.java
1495103 
>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/addwidget.jsp 1495103

>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/addwidget.marketplace.jsp
1495103 
>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/addwidget.w3c.jsp 1495103

>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/categories.jsp
1495103 
>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/preferences.jsp
1495103 
>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/users.jsp 1495103

>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/widgetdetail.jsp
1495103 
>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/widgets.jsp 1495103

>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/error.jsp 1495103 
>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/mobile_home.jsp 1495103

>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newaccount.jsp 1495103

>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1495103 
>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1495103

>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1495103 
>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/userProfile.jsp 1495103

>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1495103 
>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.marketplace.jsp
1495103 
>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag 1495103 
>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag 1495103

>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/third_party_js.tag 1495103

>   /trunk/rave-portal-resources/src/main/webapp/static/script/app.js PRE-CREATION 
>   /trunk/rave-portal-resources/src/main/webapp/static/script/core/main.js PRE-CREATION

>   /trunk/rave-portal-resources/src/main/webapp/static/script/core/rave_ajax.js 1495103

>   /trunk/rave-portal-resources/src/main/webapp/static/script/core/rave_api.js 1495103

>   /trunk/rave-portal-resources/src/main/webapp/static/script/core/rave_core.js 1495103

>   /trunk/rave-portal-resources/src/main/webapp/static/script/core/rave_opensocial.js
1495103 
>   /trunk/rave-portal-resources/src/main/webapp/static/script/core/rave_providers.js PRE-CREATION

>   /trunk/rave-portal-resources/src/main/webapp/static/script/core/rave_view_manager.js
PRE-CREATION 
>   /trunk/rave-portal-resources/src/main/webapp/static/script/core/rave_widget.js 1495103

>   /trunk/rave-portal-resources/src/main/webapp/static/script/core/rave_wookie.js 1495103

>   /trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_admin.js 1495103

>   /trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_backbone.js
1495103 
>   /trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_context.js PRE-CREATION

>   /trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_display.js PRE-CREATION

>   /trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_event_bindings.js
PRE-CREATION 
>   /trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_forms.js 1495103

>   /trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_layout.js 1495103

>   /trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_models.js 1495103

>   /trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_person_profile.js
1495103 
>   /trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_portal.js 1495103

>   /trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_store.js 1495103

>   /trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_templates.js
PRE-CREATION 
>   /trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_ui.js 1495103

>   /trunk/rave-portal-resources/src/test/javascript/rave_api_spec.js 1495103 
>   /trunk/rave-portal-resources/src/test/javascript/rave_core_spec.js 1495103 
>   /trunk/rave-portal-resources/src/test/javascript/rave_widget_spec.js 1495103 
>   /trunk/rave-portal/pom.xml 1495103 
>   /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetWrapperRenderer.java
1495103 
> 
> Diff: https://reviews.apache.org/r/12009/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Gornstein
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message