From dev-return-9047-apmail-rave-dev-archive=rave.apache.org@rave.apache.org Tue Sep 24 11:25:01 2013 Return-Path: X-Original-To: apmail-rave-dev-archive@www.apache.org Delivered-To: apmail-rave-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A53C210037 for ; Tue, 24 Sep 2013 11:25:01 +0000 (UTC) Received: (qmail 86209 invoked by uid 500); 24 Sep 2013 11:24:32 -0000 Delivered-To: apmail-rave-dev-archive@rave.apache.org Received: (qmail 86159 invoked by uid 500); 24 Sep 2013 11:24:22 -0000 Mailing-List: contact dev-help@rave.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@rave.apache.org Delivered-To: mailing list dev@rave.apache.org Received: (qmail 86137 invoked by uid 99); 24 Sep 2013 11:24:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Sep 2013 11:24:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A3F8D1C17AC; Tue, 24 Sep 2013 11:24:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7563279900411115986==" MIME-Version: 1.0 Subject: Re: Review Request 14131: Adding hasRegionWidgets method to PageResource From: "Daniel Gornstein" To: "Rohit Kalkur" , "rave" , "Daniel Gornstein" Date: Tue, 24 Sep 2013 11:24:12 -0000 Message-ID: <20130924112412.1617.34970@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Daniel Gornstein" X-ReviewGroup: rave X-ReviewRequest-URL: https://reviews.apache.org/r/14131/ X-Sender: "Daniel Gornstein" References: <20130913192554.8699.20167@reviews.apache.org> In-Reply-To: <20130913192554.8699.20167@reviews.apache.org> Reply-To: "Daniel Gornstein" --===============7563279900411115986== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14131/#review26351 ----------------------------------------------------------- Ship it! Ship It! - Daniel Gornstein On Sept. 13, 2013, 7:25 p.m., Rohit Kalkur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14131/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2013, 7:25 p.m.) > > > Review request for rave. > > > Bugs: RAVE-1058 > https://issues.apache.org/jira/browse/RAVE-1058 > > > Repository: rave > > > Description > ------- > > Adding in a hasRegionWidgets() method to the PageResource. This is used to check whether or not to hide/show the "Add widgets to this page" message. > > > Diffs > ----- > > /branches/angular/rave-portal-resources/src/main/webapp/static/css/bootstrap/less/mixins.less 1522714 > /branches/angular/rave-portal-resources/src/main/webapp/static/html/portal/tabs.html 1522714 > /branches/angular/rave-portal-resources/src/main/webapp/static/script/common/resources/PagesResource.js 1522714 > > Diff: https://reviews.apache.org/r/14131/diff/ > > > Testing > ------- > > > Thanks, > > Rohit Kalkur > > --===============7563279900411115986==--