rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erin Noe-Payne <erin.noe.pa...@gmail.com>
Subject Re: Best way to incorporate patches moving forward
Date Mon, 31 Mar 2014 19:16:18 GMT
Github's native pull request / code review system is pretty excellent,
if we are able to take advantage of it.

On Mon, Mar 31, 2014 at 1:08 PM, Matt Franklin <m.ben.franklin@gmail.com> wrote:
> On Fri, Mar 28, 2014 at 5:55 PM, Chris Geer <chris@cxtsoftware.com> wrote:
>
>> Robert, just for clarification, it's not being managed through GitHub, it's
>> just mirrored on GitHub. Apache has it's own Git infrastructure where the
>> code really lives.
>
>
>> We can support pull requests for small patches, but attaching a patch file
>> to the JIRA (assuming a signed ICLA) is still the best way.
>>
>
> I think with an ICLA on file, pull requests should suffice.  It is less
> clumsy than uploading a patch through review board.  We can also have
> GitHub PR notifications sent to the dev list.
>
>
>>
>> Chris
>>
>>
>> On Fri, Mar 28, 2014 at 2:53 PM, Robert Douglas [W2O Digital] <
>> rdouglas@w2odigital.com> wrote:
>>
>> > Hi all,
>> >
>> > Now that Rave is being managed through GitHub, I was curious what would
>> be
>> > the best way to go about applying patches? I was thinking of putting up a
>> > pull request but could also make a patch file if that's still preferable.
>> >
>> > Thanks,
>> > Robert Douglas
>> >
>> >
>> >
>>

Mime
View raw message