ripple-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brentlint...@apache.org
Subject [1/5] incubator-ripple git commit: RIPPLE-78 Unexpected prompt for App.messageChannel with Cordova 4.3.0
Date Fri, 06 Mar 2015 02:47:24 GMT
Repository: incubator-ripple
Updated Branches:
  refs/heads/master 7691a3f6b -> 1d95fed54


RIPPLE-78 Unexpected prompt for App.messageChannel with Cordova 4.3.0

Cordova 4.3.0 adds a call to App.messageChannel during app initialization (on Android). Ripple
doesn't know about the messageChannel action, and so displays the 'I Haz Cheeseburger?!?!'
prompt to request a response to the exec call.


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/7e18e0bf
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/7e18e0bf
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/7e18e0bf

Branch: refs/heads/master
Commit: 7e18e0bf9a5c14c7149b59556419ec54624cc78a
Parents: 993dc70
Author: Tim Barham <tbarham@TB-MAC.local>
Authored: Thu Mar 5 16:41:00 2015 +1000
Committer: Tim Barham <tbarham@TB-MAC.local>
Committed: Thu Mar 5 16:41:00 2015 +1000

----------------------------------------------------------------------
 lib/client/platform/cordova/2.0.0/bridge/app.js | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/7e18e0bf/lib/client/platform/cordova/2.0.0/bridge/app.js
----------------------------------------------------------------------
diff --git a/lib/client/platform/cordova/2.0.0/bridge/app.js b/lib/client/platform/cordova/2.0.0/bridge/app.js
index e507148..b7f79c9 100644
--- a/lib/client/platform/cordova/2.0.0/bridge/app.js
+++ b/lib/client/platform/cordova/2.0.0/bridge/app.js
@@ -33,5 +33,9 @@ module.exports = {
 
     overrideBackbutton: function( win, fail, args ) {
         _console.log("Native back button handler was detached.");
+    },
+
+    messageChannel: function () {
+        // NO-OP (exists to support communication from native to JavaScript)
     }
 };


Mime
View raw message