river-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Jones (JIRA)" <j...@apache.org>
Subject [jira] Commented: (RIVER-288) [PATCH] miscellaneous minor fixes - non crucial
Date Wed, 06 Feb 2008 04:41:07 GMT

    [ https://issues.apache.org/jira/browse/RIVER-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566014#action_12566014
] 

Peter Jones commented on RIVER-288:
-----------------------------------

No problem.

> you are banking on a SocketFactory, for instance, not now or ever having
> instance variables, in whatever jvm this code is running on.

Not sure why you say that-- serializable subclasses of SocketFactory can certainly have serializable
fields, and fields of their non-serializable superclasses are not serialized.  For direct
serializable subclasses, the technical requirement is that SocketFactory retains its subclass-accessible
no-arg constructor-- which of course would be an incompatible change to remove, so it is a
safe assumption.

> [PATCH] miscellaneous minor fixes - non crucial
> -----------------------------------------------
>
>                 Key: RIVER-288
>                 URL: https://issues.apache.org/jira/browse/RIVER-288
>             Project: River
>          Issue Type: Improvement
>            Reporter: Dave Brosius
>            Priority: Trivial
>         Attachments: misc_minor_fixes.patch
>
>
> just a hodgepodge of fixes, nothing critical.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message