river-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Brouwer (JIRA)" <j...@apache.org>
Subject [jira] Commented: (RIVER-286) [PATCH] iterators on synchronized collections still need synchronization
Date Sun, 03 Feb 2008 16:28:08 GMT

    [ https://issues.apache.org/jira/browse/RIVER-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565186#action_12565186
] 

Mark Brouwer commented on RIVER-286:
------------------------------------

Although Dave is correct, in this case there is no real harm as iterating takes place while
there is no concurrent access against the map (). Nevertheless applying the patch is a good
thing to do.

> [PATCH] iterators on synchronized collections still need synchronization
> ------------------------------------------------------------------------
>
>                 Key: RIVER-286
>                 URL: https://issues.apache.org/jira/browse/RIVER-286
>             Project: River
>          Issue Type: Bug
>          Components: com_sun_jini_mahalo
>            Reporter: Dave Brosius
>            Priority: Minor
>         Attachments: synchronize_iterator.patch
>
>
> Code creates a collection with Collections.synchronizedMap, and then iterates the collection
without synchronizing. This is a mistake as a map can't impose synchronization on the iterator.
This patch fixes this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message