river-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Costers (JIRA)" <j...@apache.org>
Subject [jira] Commented: (RIVER-272) ClassDep.java relies on Sun specific Internal JDK API
Date Wed, 22 Apr 2009 11:27:47 GMT

    [ https://issues.apache.org/jira/browse/RIVER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701489#action_12701489

Jonathan Costers commented on RIVER-272:

The -jar option of the java command can not be combined with the -cp option (in fact, -cp
is simply ignored). And as the ASM JARs are not in the tools.jar manifest Class-Path, they
are indeed not found. You would be able to call ClassDep directly without the -jar option
Solution would be to add the ASM JARs to the Class-Path in the tools.jar manifest.

Personally, I don't always like that mechanism at all. It forces you to keep your dependent
JARs at fixed locations, relative to the depending JAR. River makes use of it a lot though,
almost all distribution JAR files have a Class-Path in their manifest. But I suppose there
is no real alternative, aside from not using the -jar option at all :-)

About the ClassDepLoader class, I would need to take a deeper look to see if we can get rid
of it, but your explanation certainly makes sense.


> ClassDep.java relies on Sun specific Internal JDK API 
> ------------------------------------------------------
>                 Key: RIVER-272
>                 URL: https://issues.apache.org/jira/browse/RIVER-272
>             Project: River
>          Issue Type: Improvement
>          Components: com_sun_jini_tool
>    Affects Versions: jtsk_2.1
>         Environment: Windows XP, JDK 1.4 - JDK 1.6, Eclipse 3.3 IDE
>            Reporter: Hakan Kocakulak
>         Attachments: ClassDep-a4.patch, ClassDep-a5.patch, ClassDep-a6.patch, classdepend.zip,
classdepend_backport.tgz, ClassDepReplacement.tgz, ClassDepReplacement_alpha-2.tgz, ClassDepReplacement_alpha-3.tgz,
> ClassDep.java relies on Sun specific Internal JDK API 
> import sun.tools.java.BinaryClass;
> > import sun.tools.java.ClassDeclaration; import 
> > sun.tools.java.ClassFile; import sun.tools.java.ClassNotFound; import 
> > sun.tools.java.ClassPath; import sun.tools.java.Constants; import 
> > sun.tools.java.Environment; import sun.tools.java.Identifier; import 
> > sun.tools.java.MemberDefinition; import sun.tools.java.Package; import 
> > sun.tools.java.Type;
> while building from eclipse IDE, IDE do not add these Classes to classpath and can not
build project.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message