rocketmq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vongosl...@apache.org
Subject [rocketmq] branch master updated: Update PULL_REQUEST_TEMPLATE.md
Date Thu, 12 Jul 2018 05:26:44 GMT
This is an automated email from the ASF dual-hosted git repository.

vongosling pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/master by this push:
     new 0ec1c10  Update PULL_REQUEST_TEMPLATE.md
0ec1c10 is described below

commit 0ec1c106eee5dc91253bf0d2867a5d6905428c55
Author: von gosling <vongosling@apache.org>
AuthorDate: Thu Jul 12 13:26:41 2018 +0800

    Update PULL_REQUEST_TEMPLATE.md
---
 .github/PULL_REQUEST_TEMPLATE.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index eb8cb83..f66d5f5 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -12,11 +12,11 @@ XX
 
 XXXX
 
-Follow this checklist to help us incorporate your contribution quickly and easily:
+Follow this checklist to help us incorporate your contribution quickly and easily.
 
 - [x] Make sure there is a Github issue filed for the change (usually before you start working
on it). Trivial changes like typos do not require a Github issue. Your pull request should
address just this issue, without pulling in other changes - one PR resolves one issue. 
 - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config
not exist`. Each commit in the pull request should have a meaningful subject line and body.
 - [ ] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
-- [ ] Write necessary unit-test to verify your logic correction, more mock a little better
when cross module dependency exist. If the new feature or significant change is committed,
please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
+- [ ] Write necessary unit-test(over 80% coverage) to verify your logic correction, more
mock a little better when cross module dependency exist. If the new feature or significant
change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
 - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make
sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run
`mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
 - [ ] If this contribution is large, please file an [Apache Individual Contributor License
Agreement](http://www.apache.org/licenses/#clas).


Mime
View raw message