rocketmq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vongosl...@apache.org
Subject [rocketmq] branch master updated: Update PULL_REQUEST_TEMPLATE.md
Date Mon, 06 Aug 2018 07:06:02 GMT
This is an automated email from the ASF dual-hosted git repository.

vongosling pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/master by this push:
     new 820d7eb  Update PULL_REQUEST_TEMPLATE.md
820d7eb is described below

commit 820d7eb1b23e0576385f407fb2beee8eba973695
Author: von gosling <vongosling@apache.org>
AuthorDate: Mon Aug 6 15:06:00 2018 +0800

    Update PULL_REQUEST_TEMPLATE.md
---
 .github/PULL_REQUEST_TEMPLATE.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 5d13fff..0807534 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -10,11 +10,11 @@ XX
 
 XXXX
 
-Follow this checklist to help us incorporate your contribution quickly and easily:
+Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
`it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before
request the community to review your PR`.
 
-- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/)
filed for the change (usually before you start working on it). Trivial changes like typos
do not require a JIRA issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue. 
-- [ ] Format the pull request title like `[ROCKETMQ-XXX] Fix UnknownException when host config
not exist`. Each commit in the pull request should have a meaningful subject line and body.
+- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a Github issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue. 
+- [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config
not exist`. Each commit in the pull request should have a meaningful subject line and body.
 - [ ] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
-- [ ] Write necessary unit-test to verify your logic correction, more mock a little better
when cross module dependency exist. If the new feature or significant change is committed,
please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
+- [ ] Write necessary unit-test(over 80% coverage) to verify your logic correction, more
mock a little better when cross module dependency exist. If the new feature or significant
change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
 - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make
sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run
`mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
 - [ ] If this contribution is large, please file an [Apache Individual Contributor License
Agreement](http://www.apache.org/licenses/#clas).


Mime
View raw message