rocketmq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vongosl...@apache.org
Subject [rocketmq-exporter] branch master updated: Create PULL_REQUEST_TEMPLATE.md
Date Fri, 05 Jul 2019 07:38:48 GMT
This is an automated email from the ASF dual-hosted git repository.

vongosling pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-exporter.git


The following commit(s) were added to refs/heads/master by this push:
     new d091776  Create PULL_REQUEST_TEMPLATE.md
d091776 is described below

commit d091776a85b374192f5dc1ef3f23f402ab3f359d
Author: von gosling <vongosling@apache.org>
AuthorDate: Fri Jul 5 15:38:44 2019 +0800

    Create PULL_REQUEST_TEMPLATE.md
---
 .github/PULL_REQUEST_TEMPLATE.md | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
new file mode 100644
index 0000000..143dac8
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,20 @@
+## What is the purpose of the change
+
+XXXXX
+
+## Brief changelog
+
+XX
+
+## Verifying this change
+
+XXXX
+
+Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
`it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before
request the community to review your PR`.
+
+- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a Github issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue. 
+- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config
not exist`. Each commit in the pull request should have a meaningful subject line and body.
+- [x] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
+- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more
mock a little better when cross module dependency exist. If the new feature or significant
change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
+- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make
sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run
`mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
+- [ ] If this contribution is large, please file an [Apache Individual Contributor License
Agreement](http://www.apache.org/licenses/#clas).


Mime
View raw message