rocketmq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ROCKETMQ-4) Extract all RocketMQ constants from MixAll to RocketMQProperties class
Date Wed, 12 Jul 2017 06:12:00 GMT

    [ https://issues.apache.org/jira/browse/ROCKETMQ-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083501#comment-16083501
] 

Eric Liu commented on ROCKETMQ-4:
---------------------------------

The public methods and properties in *MixAll*  may be used by the projects which have dependency
on rocketmq.So, any idea to solve this situation?

> Extract all RocketMQ constants from MixAll to RocketMQProperties class
> ----------------------------------------------------------------------
>
>                 Key: ROCKETMQ-4
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-4
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>             Fix For: 4.2.0-incubating
>
>
> {{MixAll}} contains helper methods and constants that are mostly not used by those methods,
but used through all the code base.
> I propose to gather all constants into {{RocketMQProperties}} class in the same directory,
and move helper methods to {{UtilAll}}.
> Any objections?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message