rocketmq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ROCKETMQ-28) Transportation Layer Security
Date Thu, 13 Jul 2017 07:53:00 GMT

    [ https://issues.apache.org/jira/browse/ROCKETMQ-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085321#comment-16085321
] 

ASF GitHub Bot commented on ROCKETMQ-28:
----------------------------------------

Github user vsair commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/118#discussion_r127149807
  
    --- Diff: client/src/main/java/org/apache/rocketmq/client/ClientConfig.java ---
    @@ -173,12 +177,20 @@ public void setVipChannelEnabled(final boolean vipChannelEnabled)
{
             this.vipChannelEnabled = vipChannelEnabled;
         }
     
    +    public boolean isUseTLS() {
    +        return useTLS;
    +    }
    +
    +    public void setUseTLS(boolean useTLS) {
    +        this.useTLS = useTLS;
    +    }
    +
         @Override
         public String toString() {
             return "ClientConfig [namesrvAddr=" + namesrvAddr + ", clientIP=" + clientIP
+ ", instanceName=" + instanceName
                 + ", clientCallbackExecutorThreads=" + clientCallbackExecutorThreads + ",
pollNameServerInterval=" + pollNameServerInterval
                 + ", heartbeatBrokerInterval=" + heartbeatBrokerInterval + ", persistConsumerOffsetInterval="
                 + persistConsumerOffsetInterval + ", unitMode=" + unitMode + ", unitName="
+ unitName + ", vipChannelEnabled="
    -            + vipChannelEnabled + "]";
    +            + vipChannelEnabled + ", useTLS=" + useTLS + "]";
    --- End diff --
    
    it looks good to use the  ToStringBuilder  of  commons-lang.


> Transportation Layer Security
> -----------------------------
>
>                 Key: ROCKETMQ-28
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-28
>             Project: Apache RocketMQ
>          Issue Type: New Feature
>          Components: rocketmq-remoting
>            Reporter: Zhanhui Li
>            Assignee: Zhanhui Li
>             Fix For: 4.2.0-incubating
>
>
> RocketMQ delivers data in clear text for now, which requires internal network environment.
As use scenarios expand, end-to-end security is in bad need. This issue is to introduce features
making RocketMQ security for various use cases and sacrificing as few as possible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message