rocketmq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ROCKETMQ-106) Add flow control on topic level
Date Wed, 05 Jul 2017 09:50:00 GMT

    [ https://issues.apache.org/jira/browse/ROCKETMQ-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074510#comment-16074510
] 

ASF GitHub Bot commented on ROCKETMQ-106:
-----------------------------------------

Github user lizhanhui commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/66
  
    +1, @dongeforever we'd merge this PR after conflicts are resolved as we have collected
enough positive votes.


> Add flow control on topic level
> -------------------------------
>
>                 Key: ROCKETMQ-106
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-106
>             Project: Apache RocketMQ
>          Issue Type: Wish
>          Components: rocketmq-client
>            Reporter: Jaskey Lam
>            Assignee: Jaskey Lam
>             Fix For: 4.2.0-incubating
>
>
> *Motivations*
> For current flow control, we can only control on queue level. 
> Howerver, the numbers of queue allocated may be dynamic changed. For example, I might
hope to control that at most 1000 messages can be pulled from broker to protect my client.
And I have no idea how many queue I am allocated. Maybe I will have 5 queue and 5 instances
so I set `pullThresholdForQueue`=1000, which works as expected when one is fine. But as long
as any instances crashes, some instances may be allocated  more than one queue, which will
make messages pulled from broker exceed my expectations.
> A configuration of  `pullThresholdForTopic` is propably most user hopes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message