rocketmq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ROCKETMQ-233) Apply pull interval when pull result contains no new matched msg
Date Mon, 10 Jul 2017 07:01:00 GMT

    [ https://issues.apache.org/jira/browse/ROCKETMQ-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079946#comment-16079946
] 

ASF GitHub Bot commented on ROCKETMQ-233:
-----------------------------------------

Github user shroman commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/127#discussion_r126346177
  
    --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java
---
    @@ -273,6 +273,17 @@ public void pullMessage(final PullRequest pullRequest) {
             final long beginTimestamp = System.currentTimeMillis();
     
             PullCallback pullCallback = new PullCallback() {
    +
    +            private void scheduleNextPull(PullResult pullResult) {
    --- End diff --
    
    Let's have it in a comment for the method.


> Apply pull interval when pull result contains no new matched msg
> ----------------------------------------------------------------
>
>                 Key: ROCKETMQ-233
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-233
>             Project: Apache RocketMQ
>          Issue Type: Bug
>            Reporter: Zhanhui Li
>            Assignee: Zhanhui Li
>             Fix For: 4.2.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message