roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Allen Gilliland <Allen.T.Gillil...@Sun.COM>
Subject Re: svn commit: r368483 - /incubator/roller/trunk/src/org/roller/presentation/velocity/PreviewServlet.java
Date Fri, 13 Jan 2006 16:44:55 GMT
Okay, I am going to gripe about this one a bit.  I think it's rather stupid that xdoclet is
telling us how to write our code.  There is no reason why I shouldn't be able to extend a
servlet class and have both parent and child mapped as servlets.  The reason I made this change
is because I would like to tidy up the velocity servlets and rename the BasePageServlet to
just PageServlet, which makes more sense.

My feeling is that if xdoclet cannot do the job correctly then it shouldn't be used.  I am
fine with managing the servlet definitions manually if that's what it means.

-- Allen


On Fri, 2006-01-13 at 07:44, David M Johnson wrote:
> Problem in this commit. Apparently, XDoclet doesn't play nice with  
> inheritance in Servlets. You've made PreviewServlet extend  
> PageServlet, which is not necessarily a bad thing, but XDoclet is  
> confused. It's generating a mapping for /page/* to PreviewServlet,  
> which breaks Roller -- so I'm gonna back this one out.
> 
> - Dave
> 
> 
> On Jan 12, 2006, at 4:52 PM, agilliland@apache.org wrote:
> 
> > Author: agilliland
> > Date: Thu Jan 12 13:52:46 2006
> > New Revision: 368483
> >
> > URL: http://svn.apache.org/viewcvs?rev=368483&view=rev
> > Log:
> > make PreviewServlet extend PageServlet instead of BasePageServlet.
> >
> >
> > Modified:
> >     incubator/roller/trunk/src/org/roller/presentation/velocity/ 
> > PreviewServlet.java
> >
> > Modified: incubator/roller/trunk/src/org/roller/presentation/ 
> > velocity/PreviewServlet.java
> > URL: http://svn.apache.org/viewcvs/incubator/roller/trunk/src/org/
> > roller/presentation/velocity/PreviewServlet.java? 
> > rev=368483&r1=368482&r2=368483&view=diff
> > ====================================================================== 
> > ========
> > --- incubator/roller/trunk/src/org/roller/presentation/velocity/ 
> > PreviewServlet.java (original)
> > +++ incubator/roller/trunk/src/org/roller/presentation/velocity/ 
> > PreviewServlet.java Thu Jan 12 13:52:46 2006
> > @@ -30,7 +30,7 @@
> >   * @web.servlet-init-param name="properties" value="/WEB-INF/ 
> > velocity.properties"
> >   * @web.servlet-mapping url-pattern="/preview/*"
> >   */
> > -public class PreviewServlet extends BasePageServlet {
> > +public class PreviewServlet extends PageServlet {
> >
> >      private static Log mLogger = LogFactory.getLog 
> > (PreviewServlet.class);
> >
> >
> 


Mime
View raw message