roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Johnson (JIRA)" <>
Subject [jira] Resolved: (ROL-1852) Weblog member management / role assignment not working
Date Tue, 02 Mar 2010 04:11:27 GMT


Dave Johnson resolved ROL-1852.

    Resolution: Fixed

Author: snoopdave
Date: Tue Mar  2 04:03:15 2010
New Revision: 917868

Fix for "Weblog member management / role assignment not working"

Two problems:
1) JPAWeblogManager.addWeblog() was giving blog owner ADMIN and AUTHOR actions, when user
should have only 1
2) was using username where it should have used ID

I didn't use Christopher's patch, but I did use some ideas from it (i.e. the id vs. username
fix). Thanks!

> Weblog member management / role assignment not working
> ------------------------------------------------------
>                 Key: ROL-1852
>                 URL:
>             Project: Roller
>          Issue Type: Bug
>          Components: JPA Backend, User Management
>    Affects Versions: 5.0
>         Environment: jboss-4.2.3, mysql, ubuntu 9.10
>            Reporter: Christopher Blasnik
>            Assignee: David Johnson
>             Fix For: 5.0
>         Attachments: Weblog-member-management.patch
> Reassigning a weblog member's role ( / Members.jsp) does nothing on a "save"
> Reason #1: String sval = getParameter("perm-" + perms.getUser().getUserName()) is queried
in stead of " ...getUserId()."
> .) Fixing this caused another error with the JPA  revoke / grant permissions methods:
openJPA threw an exception saying that the instance was already deleted and could therefore
not be updated.
> The possible identified cause was that the revokeWeblogPermissions method did'nt commit
the transaction, therefore the object id was still there. Also, only releasing the transaction
made it possible to store the grants in the DB.
> .) Next in line: grantWeblogPermissions IMO used the wrong method: "addAction" instead
of "setActions" --> this caused the permissions to be added instead of being replaced (i.e.
leading to entries like "-1, admin, post" in roller_permission
> .) I added hashCode / equals methods to ObjectPermission and WeblogPermission (you can
scrap those if you don't need them)
> .) WeblogPermission.orm.xml: corrected typos: "true" --> "TRUE"; apparently the queries
are case-sensitive (at least on my system) which caused a lot of the permission queries /
method not to work at all.
> --> please refer to the added patch file

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message