roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Huber (JIRA)" <>
Subject [jira] Created: (ROL-1870) Duplicate bookmarks not showing
Date Wed, 30 Jun 2010 14:25:56 GMT
Duplicate bookmarks not showing

                 Key: ROL-1870
             Project: Roller
          Issue Type: Bug
          Components: Bookmark Management
    Affects Versions: 4.0.1
            Reporter: Greg Huber
            Assignee: Roller Unassigned


Noticed that bookmarks with the same name in the same folder do not show on the ui.  The method
from WeblogBookmarkFolder

public Set getBookmarks() {
        return this.bookmarks;

uses a set, but the pojo WeblogBookmark uses this equals/hashcode,  ie name and folder.  Needs
a uniqueness.  Only option is to use the id. 

public boolean equals(Object other) {
        if (other == this) return true;
        if (other instanceof WeblogBookmark != true) return false;
        WeblogBookmark o = (WeblogBookmark)other;
        return new EqualsBuilder()
        .append(getName(), o.getName())
        .append(getFolder(), o.getFolder())
    public int hashCode() {
        return new HashCodeBuilder()

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message