roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Johnson (JIRA)" <>
Subject [jira] Resolved: (ROL-569) HTML output by showBookmarks is violates HTML spec
Date Mon, 19 Jul 2010 01:09:52 GMT


David Johnson resolved ROL-569.

    Resolution: Fixed

I believe this was fixed long ago and since then I've been able to validate my blog, which
uses bookmarks against HTML 4 and more recently HTML5.

> HTML output by showBookmarks is violates HTML spec
> --------------------------------------------------
>                 Key: ROL-569
>                 URL:
>             Project: Roller
>          Issue Type: Bug
>          Components: Macros
>    Affects Versions: 1.0RC2
>         Environment:
>            Reporter: Dan price
>            Assignee: David Johnson
> I think the HTML being output by the showBookmarks() macro is somewhat busted.  I'm seeing:
> <ul class="rFolder">Solaris Kernel Folks                                   
>        <li class="rFolderItem">                                               

>          <a href="" title="Adam Leventhal"             
>  class="rBookmark0">Adam Leventhal</a>                                     
>        </li>                                                                  

> I could be wrong, but isn't it a bad idea (not HTML 4.01 compliant) to have the title
of the list inside the <ul> tag like that?
> This would be better:                        
> <div class="rFolder">Solaris Kernel Folks</div>                         
> <ul>                                                                          
> <li class="rFolderItem">...</li>                                        
> Seems like a better answer to me.  Among other problems, the current
> version's HTML output looks fairly poor.  Some compensation can be done with stylesheets,
but that's a kludge.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message