roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Johnson (JIRA)" <>
Subject [jira] Updated: (ROL-1906) Accept-Language header parsing broken
Date Sun, 27 Feb 2011 12:54:58 GMT


David Johnson updated ROL-1906:

         Priority: Minor  (was: Major)
    Fix Version/s:     (was: 5.0)

This is a problem with the underlying JSTL implementation used on the Roller JSP pages and
I am able to reproduce the error outside of Roller with a simple JSP page. JSTL is picking
the wrong locale. Roller uses the latest JSTL implementation, so the proper course of action
here is to report a bug to the JSTL developers and, if possible, create a work-around for

<%@ taglib uri="" prefix="c" %>
<%@ taglib uri=""  prefix="fmt" %>
<fmt:setBundle basename="ApplicationResources" />
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "">
<html xmlns="">
        <title><fmt:message key="error.title.404" /></title>

Only the Roller editor/admin page is effected by this bug, not blog pages which use Servlet
API directly.

This seems like a pretty minor issue, do "real users" really put Relative Quality Factors
in their Accept-Langauge header?

> Accept-Language header parsing broken
> -------------------------------------
>                 Key: ROL-1906
>                 URL:
>             Project: Roller
>          Issue Type: Bug
>    Affects Versions: 5.0
>         Environment:
>            Reporter: Mark Thomas
>            Assignee: Roller Unassigned
>            Priority: Minor
> The following request returns a 404 message in German when it should be in English. I
have tested the underlying Tomcat ServletRequest.getLocale() implementation and that does
return the correct value.
> GET /foo/bar HTTP/1.1
> Host:
> Accept-Language: en,de;q=0.5
> Version is Version 5.0.0-RC1 (r990388) 

This message is automatically generated by JIRA.
For more information on JIRA, see:


View raw message