roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Glen Mazza (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (ROL-1413) i18n locale determine problems of roller ui and rendering system
Date Wed, 26 Feb 2014 09:05:32 GMT

     [ https://issues.apache.org/jira/browse/ROL-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Glen Mazza closed ROL-1413.
---------------------------

    Resolution: Not A Problem

Item from 2007.  From comments thread, much/most of this issue has been taken care of and
the remainder may not be relevant today.

> i18n locale determine problems of roller ui and rendering system
> ----------------------------------------------------------------
>
>                 Key: ROL-1413
>                 URL: https://issues.apache.org/jira/browse/ROL-1413
>             Project: Apache Roller
>          Issue Type: Bug
>          Components: User Interface (Other)
>         Environment: Any
>            Reporter: Miles Huang
>            Assignee: Roller Unassigned
>         Attachments: ASF.LICENSE.NOT.GRANTED--i18n.patch
>
>
> Roller uses many ways to implement i18n messages.
> Consider following locales:
> Locale.getDefaultLocale(),
> request.getLocale(),
> RollerSession.getRollerSession(request).getAuthenticatedUser().getLocale()
> More cumbersome, current codes use different locales to get i18n message, which leads
to different languages even on a single page.
> For a real web site for global users, it's quit common that all these locales have different
values.
> In detail, following java classes and JSP pages have problem on i18n locale determine
algorithm:
> The MessageUtilities.java: Use JVM default locale blindly, leave user preferred locale
unchecked.
> The UtilitiesModel: Its formatDate methods use JVM default locale blindly.
> The StrutsCharEncodingFilter.java and taglibs.jsp: new Locale(String) will construct
a locale instance which has only language part without country part, passing a '_' delimited
locale string to the construtor , eg. new Locale("en_US"), is buggy. Everywhere there are
getLocaleInstance() methods which do the right thing.
> The taglibs.jsp: Change JSTL fmt locale to authenticated user's locale only, leaves struts
MessageResource locale setting along.
> The WeblogTemplateFormAction, BasePageModel, CommentServlet, SearchResultsModel, SearchResultsFeedModel,
SearchResultsPager, SearchResultsFeedPager: Use a static ResourceBundle instance for all requests,
does every one speaking same language? ;-)
> The StrutsUtil: single localeBeans and timeZoneBeans for the whole world.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message