roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Huber (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ROL-1994) Switch to Apache Commons Collections 4.0
Date Tue, 17 Jun 2014 16:11:28 GMT

    [ https://issues.apache.org/jira/browse/ROL-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033961#comment-14033961
] 

Greg Huber commented on ROL-1994:
---------------------------------

These just sort by date reverse if I remember correctly.  Think I replaced this "locally"
with the arrival sequence of the data from the database as it was easier to change the order.

private Map<Date, TreeSet<WeblogEntryWrapper>> results
            = new TreeMap<Date, TreeSet<WeblogEntryWrapper>>(new ReverseComparator());

private LinkedHashMap<String, TreeSet<SearchResultsObject>> results = new LinkedHashMap<String,
TreeSet<SearchResultsObject>>();

> Switch to Apache Commons Collections 4.0
> ----------------------------------------
>
>                 Key: ROL-1994
>                 URL: https://issues.apache.org/jira/browse/ROL-1994
>             Project: Apache Roller
>          Issue Type: Task
>    Affects Versions: 5.1
>            Reporter: Glen Mazza
>            Assignee: Roller Unassigned
>            Priority: Minor
>
> In five places we're using a nongeneric "ReverseComparator()" causing IntelliJ idea complaints
that we're doing an unchecked assignment.  Commons Collections 4 supports generic types: https://commons.apache.org/proper/commons-collections/release_4_0.html,
https://commons.apache.org/proper/commons-collections/javadocs/api-release/org/apache/commons/collections4/comparators/ReverseComparator.html.
> A better fix might be to stop using this library altogether and just rely on what the
JDK provides, if possible.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message