roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Huber (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ROL-2002) https:// URLs not being processed correctly in the comment URL field
Date Mon, 09 Jun 2014 09:08:01 GMT

    [ https://issues.apache.org/jira/browse/ROL-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14021761#comment-14021761
] 

Greg Huber commented on ROL-2002:
---------------------------------

Have moved the business logic from the javascript to the comment servlet and added some basic
validation requiring now a valid url, similar to the email validation.

ie:
{code:java}
} else if (commentRequest.getUrl() != null) {
            String[] customSchemes = { "http", "https" };
            if (!new UrlValidator(customSchemes).isValid(commentRequest
                    .getUrl())) {
                error = messageUtils.getString("error.commentPostFailedURL");
                log.debug("URl is invalid : " + commentRequest.getUrl());
            }
 }
{code}

> https:// URLs not being processed correctly in the comment URL field
> --------------------------------------------------------------------
>
>                 Key: ROL-2002
>                 URL: https://issues.apache.org/jira/browse/ROL-2002
>             Project: Apache Roller
>          Issue Type: Bug
>          Components: Comments
>    Affects Versions: 5.1
>            Reporter: Glen Mazza
>            Assignee: Greg Huber
>
> If a commenter has an https:// URL, Roller incorrectly prepends an http:// to it, for
example:  http://https://web-gmazza.rhcloud.com/blog



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message