roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kohei Nozaki (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ROL-2065) Gaurav renders the summary of an entry as unresolved "$entry.summary" while no summary in the entry
Date Sat, 28 Feb 2015 02:39:05 GMT
Kohei Nozaki created ROL-2065:
---------------------------------

             Summary: Gaurav renders the summary of an entry as unresolved "$entry.summary"
while no summary in the entry
                 Key: ROL-2065
                 URL: https://issues.apache.org/jira/browse/ROL-2065
             Project: Apache Roller
          Issue Type: Bug
          Components: Themes and Macros
    Affects Versions: 5.1.1
            Reporter: Kohei Nozaki
            Assignee: Roller Unassigned
            Priority: Minor


day.vm in Gaurav checks existence of summary in following code:

{code:html}
#if($entry.summary != "")
    <p>$entry.summary</p>
    <a class="btn btn-primary" href="$url.entry($entry.anchor)">Read More <i class="icon-angle-right"></i></a>
#else
    <p>$entry.displayContent</p>
#end
{code}

I experienced WEBLOGENTRY.SUMMARY went null accidentally (https://twitter.com/lbtc_xxx/status/549181370908430338).
in such case, Gaurav thinks the summary is exist and render it as "$entry.summary". I don't
know how summary went null, but the db schema allows null so I guess changing comparison logic
to more safer one (use $utils.isNotEmpty() instead) is reasonable.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message