roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aditya Sharma (JIRA)" <>
Subject [jira] [Commented] (ROL-2138) NOTICE file does not have standard content
Date Wed, 12 Jun 2019 11:26:00 GMT


Aditya Sharma commented on ROL-2138:

Thanks [~sebb] for the review :)
{quote}The NOTICE file includes the line:

"This product includes software developed by"

I'm not sure where you got that from, but it is incorrect.
The lines are there in sublinks see [here|]

I went through some other sub links and as per [this|]

??Copyright notifications which have been [relocated|]
from source files (rather than removed) must be preserved in {{NOTICE}}. However, elements
such as the copyright notifications embedded within BSD and MIT licenses need not be duplicated
in {{NOTICE}} -- it suffices to leave those notices in their original locations.??

So I kept all the copyright notices as it is. 
Though I will go through the content again, please correct me if I missed on something.



> NOTICE file does not have standard content
> ------------------------------------------
>                 Key: ROL-2138
>                 URL:
>             Project: Apache Roller
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Aditya Sharma
>            Priority: Critical
>          Time Spent: 10m
>  Remaining Estimate: 0h
> The NOTICE file in the 5.2.2 release does not have the standard format [1] for a NOTICE
> It does not have the standard header.
> It also contains material which should not be present.
> Note that the NOTICE and LICENSE files must only include details of software which is
actually included in the bundle to which they relate. In this case, the binary bundle contains
3rd party (and other ASF) software, so the NOTICE and LICENSE files should be different.
> Furthermore, the text of all relevant licenses must be included in the bundle; links
to external licenses are not sufficient. The license text can either be appended to the LICENSE
file, or included in separate files linked from the LICENSE file.
> [1]

This message was sent by Atlassian JIRA

View raw message