roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adityasha...@apache.org
Subject [roller] branch master updated: Fixed: sonarqube issue - Empty blocks should be removed Leftover empty blocks are usually introduced by mistake. They are useless and prevent readability of the code. They should be removed or completed with real code.
Date Mon, 04 Jan 2021 08:08:52 GMT
This is an automated email from the ASF dual-hosted git repository.

adityasharma pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/roller.git


The following commit(s) were added to refs/heads/master by this push:
     new 50a4a09  Fixed: sonarqube issue - Empty blocks should be removed Leftover empty blocks
are usually introduced by mistake. They are useless and prevent readability of the code. They
should be removed or completed with real code.
     new 07dcff1  Merge branch 'master' of https://github.com/apache/roller
50a4a09 is described below

commit 50a4a093e76ad04d2cdf4c10d327179ee974ba67
Author: Aditya Sharma <adityasharma@apache.org>
AuthorDate: Mon Jan 4 13:34:20 2021 +0530

    Fixed: sonarqube issue - Empty blocks should be removed
    Leftover empty blocks are usually introduced by mistake. They are useless and prevent
readability of the code. They should be removed or completed with real code.
---
 app/src/main/webapp/roller-ui/styles/layout.css |  6 ++----
 app/src/main/webapp/themes/base.css             | 16 +++-------------
 2 files changed, 5 insertions(+), 17 deletions(-)

diff --git a/app/src/main/webapp/roller-ui/styles/layout.css b/app/src/main/webapp/roller-ui/styles/layout.css
index 3c99aff..4433f3b 100644
--- a/app/src/main/webapp/roller-ui/styles/layout.css
+++ b/app/src/main/webapp/roller-ui/styles/layout.css
@@ -44,15 +44,13 @@ layout.css: Base CSS layout for Roller's web UI (position and sizing only)
 #menu {
     padding: 0px 10px 0px 10px;
 }
-#content {
-}
-/*  
+/*
     NOTE: these wrap divs are kinda lame, however they are necessary.
     the problem is that when 2 divs are floated side-by-side then the
     calculation of their widths does not include padding or margins.
 
     so without the wrap divs then putting a margin or padding value in any
-    of the XXXcontent divs forces the width calculation to be > 100% and 
+    of the XXXcontent divs forces the width calculation to be > 100% and
     the divs don't fit next to each other anymore :(
 
     to get around this we put a XXXcontent_wrap around the XXXcontent divs
diff --git a/app/src/main/webapp/themes/base.css b/app/src/main/webapp/themes/base.css
index 32514c9..39de80d 100644
--- a/app/src/main/webapp/themes/base.css
+++ b/app/src/main/webapp/themes/base.css
@@ -22,10 +22,6 @@ a {
     font-weight: normal;
     text-decoration: underline;
 }
-a:active {}
-a:link {}
-a:visited {}
-a:hover {}
 body {
     font-family: verdana, sans-serif;
     font-size: small;
@@ -49,7 +45,7 @@ pre {
 }
 img {
     border: 0px;
-    margin: 0px; 
+    margin: 0px;
 }
 
 /* bookmark.vm */
@@ -136,7 +132,7 @@ div.comments-head {
 }
 /* actual comment content */
 .comment {
-    margin: 5px 10px 10px 5px; 
+    margin: 5px 10px 10px 5px;
 }
 /* commenter info */
 p.comment-details {
@@ -194,8 +190,6 @@ textarea.commentFormTextarea {
     color: red;
     font-style: italic;
 }
-div.commentBody {}
-div.commentByline {}
 div.commentAuthor {
     border: none;
 }
@@ -214,8 +208,6 @@ span.disabled {
 span.enabled {
     color: green;
 }
-form#searchForm {
-}
 div#searchAgain {
   border: 1px solid #999;
   font-size: 1em;
@@ -299,8 +291,6 @@ table.hCalendarTable {
 td.hCalendarMonthYearRow {
     font-weight: bold;
 }
-a.hCalendarNavBar {
-}
 th.hCalendarDayNameRow {
     text-align : center;
     font-size : x-small;
@@ -334,7 +324,7 @@ td.hCalendarDay {
     font-size : x-small;
 }
 
-/* BigWeblogCalendarModel */ 
+/* BigWeblogCalendarModel */
 
 div.hCalendarDayTitleBig {
   position: relative;


Mime
View raw message