royale-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] hcsuk commented on issue #341: Adding listener for when a bindable style has changed
Date Sat, 10 Nov 2018 06:25:12 GMT
hcsuk commented on issue #341: Adding listener for when a bindable style has changed
URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437562174
 
 
   Hi
   
   So having worked through this and tried a few things, I think I've come to the same conclusion
as you have: we need to keep a reference to the UI object (the strand) within our BindableCSSStyles
object, and the simplest way of doing that is making it a bead.
   
   I agree that it's weird to have BindableCSSStyles needing to be assigned via the beads
list rather than via the style property, that seems to inconsistent, so I think if we hid
this from the end user they could just add it as normal as the style, and internally we check
for the IBead interface. I looked into using IDocument but the document object isn't necessarily
the same as the strand, so this didn't work.
   
   I put together a sample and uploaded it to [https://github.com/ajwfrost/royale-playground/tree/master/StylesBinding](https://github.com/ajwfrost/royale-playground/tree/master/StylesBinding)
- the changes being proposed are in the src/changes folder. I'm not massively happy with the
updates required to UIBase but am not sure there's a better alternative..
   
   Let me know what you think! Thanks..
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message