royale-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] aharui commented on issue #341: Adding listener for when a bindable style has changed
Date Sat, 10 Nov 2018 07:41:51 GMT
aharui commented on issue #341: Adding listener for when a bindable style has changed
URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437565456
 
 
   Thanks for experimenting.  I agree with your sentiments about the amount of code in the
styles setter.
   
   Some options we have are to dictate that:
   1) the styles property can only be set to an object once (you can set it to a string multiple
times since you can do that in HTML).  Then you wouldn't need to remove the bead from the
strand
   2) require that all objects (except Strings) assigned to the styles property be IBeads.
   
   In addition, it might be that we can alter the API of applyStyles to take a third parameter
that is a list of properties to set.  Then you wouldn't have to create the temporary object
and can just pass in the entire BindableCSSValuesImpl.
   
   That might cut down on the amount of code in UIBase "just-in-case".
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message