royale-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] hcsuk commented on issue #341: Adding listener for when a bindable style has changed
Date Mon, 12 Nov 2018 13:52:43 GMT
hcsuk commented on issue #341: Adding listener for when a bindable style has changed
URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437888257
 
 
   Given that we have some dynamic objects being created for styles (e.g. when parsed from
a string), and also given the simple style types don't need a reference back to the host UI
object, I'm thinking that it would add unnecessary complexity to force our 'style' objects
to all implement a particular interface - it doesn't seem worth creating a new base type just
for this, when most of the time it won't actually be needed.
   
   So I'm thinking perhaps it's just the bindable styles that need to have the host object
to be set through the `IStyleObject` interface (possibly renaming this to `IBindableStyleObject`
for clarity?). Given they're already deriving from EventDispatcher, and there are only two
bindable style objects currently, we can just add the implementation/listener code directly
into them. This means the 'simple' case stays as simple as it currently is, and we're only
impacting the 'bindable' ones to make them work properly..
   
   I'll make the updates shortly so that you can see what I mean via code..
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message