royale-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] aharui commented on issue #341: Adding listener for when a bindable style has changed
Date Tue, 13 Nov 2018 01:51:01 GMT
aharui commented on issue #341: Adding listener for when a bindable style has changed
URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-438099383
 
 
   The changes look ok to me.  From what I could tell, IStyleObject was never used anywhere,
so having to add it to UIBase means that HelloWorld gets slightly bigger, but I couldn't think
of an alternative implementation.
   
   I would leave the name as IStyleObject.  You never know when someone else may need a reference
to the host object.  It may not always be for binding.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message