royale-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [royale-asjs] carlosrovira commented on pull request #881: ErrorImageButton Bead for ImageButton controls (Tested in Basic and J…
Date Sun, 12 Jul 2020 10:56:02 GMT

carlosrovira commented on pull request #881:
URL: https://github.com/apache/royale-asjs/pull/881#issuecomment-657206000


   @mjesteve I did some changes in ErrorImage to improve code so you can take a look:
   - Extends from Bead to avoid IEventDispatcher (that means "removeEventListener" in beadsHandler
was removed, but is a better trade off for a Basic bead.
   - hotModel stores in _hostModel to avoid making a "getBeadByType"  each time
   
   a part from that:
   - Added a default src ("assets/no-image.svg"), so we can avoid to add this property each
time.
   
   I'll check later ErrorImageButton, since I think it could be not needed by using just ImageModel
that is common in ErrorImage in an extended way, but I  need to check if I'm right.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message