samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthieu Morel <>
Subject Re: [DISCUSS] Contributing patches
Date Thu, 15 Jan 2015 14:08:15 GMT

I'd prefer to use github's pull request features:

asf infra and github are now tightly integrated (see:

This means it is possible to use github's features to submit pull
requests, which can be reviewed on github, voted upon, then merged
into the asf git repo. As far as I understand, for the integration to
happen on a particular issue, one just needs to first create a Jira
ticket and reference it from the github PR.

Jira remains the central place for handling tickets. The asf git repo
remains the source of truth for the codebase.

It's alway possible to accept git diffs (properly generated), but in
my view, accepting PRs through Github looks like the most convenient
way to handle contributions. Apache Storm and Apache Helix for
instance already take advantage of this integration.

Once a PR is accepted, apparently a committer must manually push the
patch to the asf repo , though maybe this can be automated.


On Thu, Jan 15, 2015 at 12:52 PM, Gianmarco De Francisci Morales
<> wrote:
> Hi,
> I wanted to discuss about how we will handle contributing code to SAMOA.
> In other projects, the typical Apache voting process is to require two +1's
> for code contributed by other people, and one +1 for code developed by a
> contributor.
> Voting happens on the Jira tracking the issue, and each code change is
> associated with a Jira issue.
> I think that's a reasonable way to do it.
> I don't have much experience on how to handle things with git in this
> process though.
> Should we attach diffs to the Jira anyway? What about pull requests on the
> GitHub mirror?
> Maybe Matthieu can help us here, as S4 was already using git.
> Cheers,
> --
> Gianmarco

View raw message