samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suneel Marthi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SAMOA-13) Create "how to contribute" guide
Date Wed, 04 Feb 2015 21:17:35 GMT

    [ https://issues.apache.org/jira/browse/SAMOA-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305980#comment-14305980
] 

Suneel Marthi commented on SAMOA-13:
------------------------------------

Added this comments on the PR, capturing them here again for the record.

Not sure what the Sun conventions are with regards to imports.  We should avoid all import
*, that's something that's strictly adhered to in other projects like Mahout, Flink, Oryx.
 Also a line or 2 about the order of imports would be good. 
Typically its been 

{Code}

import java.*
<space>
import 3rd party library implementations
<space>
import project specific classes

{Code}

Samoa could define its own convention but it should be documented somewhere and adhered to
for all code contributions.

> Create "how to contribute" guide
> --------------------------------
>
>                 Key: SAMOA-13
>                 URL: https://issues.apache.org/jira/browse/SAMOA-13
>             Project: SAMOA
>          Issue Type: Bug
>            Reporter: Matthieu Morel
>
> Given that we'd prefer contributions through github, we should update the CONTRIBUTING.md
file at the root of the project.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message