samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arinto <...@git.apache.org>
Subject [GitHub] incubator-samoa pull request: SAMOA-7: Unnecessary distance method...
Date Mon, 09 Mar 2015 07:57:01 GMT
Github user arinto commented on a diff in the pull request:

    https://github.com/apache/incubator-samoa/pull/15#discussion_r26019206
  
    --- Diff: samoa-api/src/main/java/com/yahoo/labs/samoa/evaluation/measures/SilhouetteCoefficient.java
---
    @@ -60,6 +60,7 @@ public void evaluateClustering(Clustering clustering, Clustering trueClustering,
         for (int p = 0; p < points.size(); p++) {
           DataPoint point = points.get(p);
           ArrayList<Integer> ownClusters = new ArrayList<>();
    +      double pointInclusionProbThreshold = 0.8;
    --- End diff --
    
    What if we use `private static final double` for this threshold?
    So that the threshold is immutable and we don't need unnecessary declaration in line 63.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message