samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gdfm <...@git.apache.org>
Subject [GitHub] incubator-samoa pull request: SAMOA-40: Add Kafka stream reader mo...
Date Tue, 21 Jul 2015 11:15:57 GMT
Github user gdfm commented on the pull request:

    https://github.com/apache/incubator-samoa/pull/32#issuecomment-123266284
  
    @karande thanks for posting this patch.
    I have a few doubts about the high-level concepts, but it's a good starting point and
we should be able to iterate on the design until we converge.
    The most important point is separation of concerns: reading from Kafka should not assume
a specific format, and parsing should happen in a separate class for handling ARFF format
(or other formats as we add support to them).
    The format type can be passed as a command line parameter (we rely on the user knowing
the format of their data).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message