samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (SAMOA-29) Remove hardcoded value for the duration of Storm local topology execution
Date Fri, 07 Aug 2015 08:39:45 GMT


ASF GitHub Bot commented on SAMOA-29:

Github user gdfm commented on the pull request:
    Hey @jayadeepj, thanks for taking a look at the issue.
    I manually checked the PR and it passes tests (we need to reduce log verbosity so Travis-CI
does not bail out).
    The code looks good to me, however I was unable to make it work as expected.
    I set "samoa.storm.local.mode.execution.duration=1" in the properties file, and ran 
    bin/samoa local target/SAMOA-Local-0.4.0-incubating-SNAPSHOT.jar "PrequentialEvaluation
-i 10000000"
    The topology kept on going until the end, while I expected it to be killed after 1 second.
    Any ideas?

> Remove hardcoded value for the duration of Storm local topology execution
> -------------------------------------------------------------------------
>                 Key: SAMOA-29
>                 URL:
>             Project: SAMOA
>          Issue Type: Bug
>          Components: SAMOA-Storm
>            Reporter: Gianmarco De Francisci Morales
> From GitHub:
> In Storm local mode, the topology always executes for at most 10 minutes.
> Refer to line 72.
> Possible solutions:
> 1) Add a new option to determine local topology execution duration in bin\,
use bin\samoa to parse the new option and pass to LocalStormDoTask as program argument.
> 2) Add the same new option as solution 1, use commons-configuration package to parse
> For the second solution, we modify LocalStormDoTask to read the
using PropertiesConfiguration class of Apache commons-configuration. It will eliminate bash-code
parsing in bin/samoa for all options except for $MODE_ARG.

This message was sent by Atlassian JIRA

View raw message