samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SAMOA-29) Remove hardcoded value for the duration of Storm local topology execution
Date Fri, 07 Aug 2015 10:07:46 GMT

    [ https://issues.apache.org/jira/browse/SAMOA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661583#comment-14661583
] 

ASF GitHub Bot commented on SAMOA-29:
-------------------------------------

Github user gdfm commented on the pull request:

    https://github.com/apache/incubator-samoa/pull/34#issuecomment-128662403
  
    @jayadeepj sorry you are right. I confused the two "local" modes.
    I re-tested it with
    ```
    bin/samoa storm target/SAMOA-Storm-0.4.0-incubating-SNAPSHOT.jar "PrequentialEvaluation
-i 10000000"
    ```
    And configuration
    ```
    samoa.storm.mode=local
    samoa.storm.numworker=4
    samoa.storm.local.mode.execution.duration=1
    ```
    but I still managed to get to the end of the evaluation.
    ```
    41052 [Thread-9-org.apache.samoa.evaluation.EvaluatorProcessor_1] INFO  org.apache.samoa.evaluation.EvaluatorProcessor
- total evaluation time: 35 seconds for 10000000 instances
    ```



> Remove hardcoded value for the duration of Storm local topology execution
> -------------------------------------------------------------------------
>
>                 Key: SAMOA-29
>                 URL: https://issues.apache.org/jira/browse/SAMOA-29
>             Project: SAMOA
>          Issue Type: Bug
>          Components: SAMOA-Storm
>            Reporter: Gianmarco De Francisci Morales
>
> From GitHub:
> In Storm local mode, the topology always executes for at most 10 minutes.
> Refer to com.yahoo.labs.samoa.LocalStormDoTask line 72.
> Possible solutions:
> 1) Add a new option to determine local topology execution duration in bin\samoa-storm.properties,
use bin\samoa to parse the new option and pass to LocalStormDoTask as program argument.
> 2) Add the same new option as solution 1, use commons-configuration package to parse
bin\samoa-storm.properties.
> For the second solution, we modify LocalStormDoTask to read the samoa-storm.properties
using PropertiesConfiguration class of Apache commons-configuration. It will eliminate bash-code
parsing in bin/samoa for all options except for $MODE_ARG.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message