samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (SAMOA-29) Remove hardcoded value for the duration of Storm local topology execution
Date Fri, 07 Aug 2015 14:51:46 GMT


ASF GitHub Bot commented on SAMOA-29:

Github user jayadeepj commented on the pull request:
    Hi @gdfm, yes you are right. I had made a compile time addition of the property file to
the jar in pom.xml. I did that to avoid a code like this
    _config = new PropertiesConfiguration(/some/hardcoded/path/to/bin/
    Also We may not be able to simply omit from the jar, as the
need to be in classpath for the PropertiesConfiguration to pick it up.  The second alternative
that is to update the bin/samoa script to add 'bin' directory to the CLASSPATH something like

    java -cp $CLASSPATH org.apache.samoa.LocalStormDoTask $COMPLETE_ARG $NUM_WORKER_
    In this second alternative, we may need to update pom.xml to include a testResources as
well for the storm junits. Let me know your thoughts. Will be happy to implement.

> Remove hardcoded value for the duration of Storm local topology execution
> -------------------------------------------------------------------------
>                 Key: SAMOA-29
>                 URL:
>             Project: SAMOA
>          Issue Type: Bug
>          Components: SAMOA-Storm
>            Reporter: Gianmarco De Francisci Morales
> From GitHub:
> In Storm local mode, the topology always executes for at most 10 minutes.
> Refer to line 72.
> Possible solutions:
> 1) Add a new option to determine local topology execution duration in bin\,
use bin\samoa to parse the new option and pass to LocalStormDoTask as program argument.
> 2) Add the same new option as solution 1, use commons-configuration package to parse
> For the second solution, we modify LocalStormDoTask to read the
using PropertiesConfiguration class of Apache commons-configuration. It will eliminate bash-code
parsing in bin/samoa for all options except for $MODE_ARG.

This message was sent by Atlassian JIRA

View raw message