samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release SAMOA 0.4.0 (incubating) RC0
Date Sun, 03 Jul 2016 00:45:10 GMT
Hi,

+0 due to possible NOTICE issue, source headers and copyright years being incorrect.

I checked:
- file names contain incubating
- NOTICE file year is incorrect, and may be missing something.
- LICENSE is good
- All source file have ASF headers. But they are non standard as there's no need to put the
copyright years (and the year is incorrect) [1]
- No unexpected binary files in source release
- All source file have ASF headers
- Can compile from source

Looks like you are including Apache 2.0 gradlew, this has a NOTICE file [2] Has this NOTICE
file been looked at to see if anything needs to go into your NOTICE file? [3]
(To make things difficult it looks like they have incorrectly stuffed license info in the
NOTICE file.)

Would be best if the release artefacts were signed by an apache.org email address.

Any reason for a seperate samoa-0.4.0-incubating.pom?

Thanks,
Justin

1. http://www.apache.org/legal/src-headers.html#headers
2. https://github.com/linkedin/linkedin-utils/blob/master/NOTICE.txt
3. http://www.apache.org/dev/licensing-howto.html#alv2-dep
Mime
View raw message