samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-samoa] csterling commented on issue #46: Code cleanups and warnings
Date Mon, 18 Nov 2019 21:46:04 GMT
csterling commented on issue #46: Code cleanups and warnings
URL: https://github.com/apache/incubator-samoa/pull/46#issuecomment-555223927
 
 
   > I like very much the cleanup. However, I see some changes in the code of RandomRBFGeneratorEvents,
Can you explain why these changes are needed? Thanks!
   
   @abifet It seems to me that the code changes you mentioned are the removal of dead code
branches (i.e. the conditions are impossible to satisfy).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message