samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Riccomini" <criccom...@apache.org>
Subject Re: Review Request 15721: Fix SAMZA-87
Date Wed, 20 Nov 2013 20:34:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15721/#review29188
-----------------------------------------------------------



samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala
<https://reviews.apache.org/r/15721/#comment56333>

    Not crazy about otherErrors and remainingErrors, but I can't come up with a better name.



samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala
<https://reviews.apache.org/r/15721/#comment56334>

    Can you a comment about the NO LONGER IN MAP thing? I'm not quite sure I understand the
scenario under which this would be triggered, or what it means.



samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala
<https://reviews.apache.org/r/15721/#comment56335>

    What does None mean here?


- Chris Riccomini


On Nov. 20, 2013, 7:32 p.m., Jakob Homan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15721/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2013, 7:32 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-87
>     https://issues.apache.org/jira/browse/SAMZA-87
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-87
> 
> 
> Diffs
> -----
> 
>   build.gradle f30128f 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala f4f616e

>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/DefaultFetch.scala 41710f2

>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/GetOffset.scala 326d6c9 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala
9b83259 
>   samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala 85f5887

> 
> Diff: https://reviews.apache.org/r/15721/diff/
> 
> 
> Testing
> -------
> 
> There's a unit test
> 
> 
> Thanks,
> 
> Jakob Homan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message