samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan" <jgho...@apache.org>
Subject Re: Review Request 15721: Fix SAMZA-87
Date Wed, 27 Nov 2013 22:36:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15721/
-----------------------------------------------------------

(Updated Nov. 27, 2013, 2:36 p.m.)


Review request for samza.


Changes
-------

Copy and paste is fun:

    Refactors refreshBrokers s.t. when there is an exception while adding one, we don't try
to re-add all of them. Also makes it a bit more efficient and, I think, easier to understand
    Fixes an issue in GetOffset when the lastcheckpointed value is the same as the high watermark,
ie no more messages have been written to that topic since checkpointing, and there was no
head to pick from.


Bugs: SAMZA-87
    https://issues.apache.org/jira/browse/SAMZA-87


Repository: samza


Description
-------

SAMZA-87


Diffs (updated)
-----

  build.gradle f30128f 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala f4f616e 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/DefaultFetch.scala 41710f2 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/DefaultFetchSimpleConsumer.scala
PRE-CREATION 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/GetOffset.scala 326d6c9 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala 7624a8e

  samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala 85f5887 

Diff: https://reviews.apache.org/r/15721/diff/


Testing
-------

There's a unit test


Thanks,

Jakob Homan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message