samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yan Fang" <yanfang...@gmail.com>
Subject Review Request 22276: SAMZA-144
Date Thu, 05 Jun 2014 19:30:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22276/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

Add stream-level overrides for kafka fetch size config

1. added getFetchMessageMaxBytesTopics method which returns a map topic->fetchSize
2. used a tuple (default value, map) for all fetchSize variable. First element is the default
or shared fetch size value, second element is the map from 1)
3. changed relevent class/methods (BrokerProxy, KafkaSystemConsumer, DefaultFetchSimpleConsumer)
to accept the new type of fetch size
4. unit test


Diffs
-----

  samza-kafka/src/main/scala/org/apache/samza/config/KafkaConfig.scala 4deabd3 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala e08791f 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/DefaultFetchSimpleConsumer.scala
d90ca78 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala f1edda0

  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala f4dc1c1

  samza-kafka/src/test/scala/org/apache/samza/config/TestKafkaConfig.scala 93cf5a5 
  samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala 9c0ca60 

Diff: https://reviews.apache.org/r/22276/diff/


Testing
-------


Thanks,

Yan Fang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message