samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Kleppmann" <mkleppm...@linkedin.com>
Subject Re: Review Request 22382: Add more file headers
Date Tue, 10 Jun 2014 11:22:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22382/#review45216
-----------------------------------------------------------



docs/sitemap.xml
<https://reviews.apache.org/r/22382/#comment79943>

    I just noticed that some (but not all) of the HTML, Markdown and XML files use <!---
... ---> (three dashes) for comments, rather than the usual <!-- ... -->. Was that
deliberate? My editor's syntax highlighting is unhappy about the triple-dash version; might
be safest to make them all two-dash comments.



docs/sitemap.xml
<https://reviews.apache.org/r/22382/#comment79942>

    AFAIK, the XML standard requires the <?xml?> processing instruction to be the first
thing in the file (since it's used by parsers for charset detection). So the license comment
must be after this line.


- Martin Kleppmann


On June 9, 2014, 9:01 p.m., Jakob Homan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22382/
> -----------------------------------------------------------
> 
> (Updated June 9, 2014, 9:01 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-92
>     https://issues.apache.org/jira/browse/SAMZA-92
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> More headers
> 
> 
> Diffs
> -----
> 
>   build.gradle 1a1db16 
>   docs/Makefile 93a1a39 
>   docs/README.md 0c1d55c 
>   docs/_config.yml bc84c84 
>   docs/_layouts/default.html 7ae7231 
>   docs/_layouts/page.html 007adf9 
>   docs/_tools/generate-javadocs.sh 0a2e430 
>   docs/_tools/publish-site.sh 285c9e7 
>   docs/community/committers.md bbc0a60 
>   docs/community/irc.md ac191e5 
>   docs/community/mailing-lists.md fa2748d 
>   docs/contribute/code.md 4b25f59 
>   docs/contribute/coding-guide.md cdcb0ea 
>   docs/contribute/disclaimer.md 3fe446f 
>   docs/contribute/projects.md ee1932d 
>   docs/contribute/rules.md 5644b6a 
>   docs/contribute/seps.md 71342fd 
>   docs/index.md a070089 
>   docs/learn/documentation/0.7.0/api/overview.md 489ba6d 
>   docs/learn/documentation/0.7.0/comparisons/introduction.md 6ecffcf 
>   docs/learn/documentation/0.7.0/comparisons/mupd8.md 2cc8ee6 
>   docs/learn/documentation/0.7.0/comparisons/storm.md 379dc31 
>   docs/learn/documentation/0.7.0/container/checkpointing.md 6a93d84 
>   docs/learn/documentation/0.7.0/container/event-loop.md 903ef90 
>   docs/learn/documentation/0.7.0/container/jmx.md 9fce867 
>   docs/learn/documentation/0.7.0/container/metrics.md 98acd81 
>   docs/learn/documentation/0.7.0/container/samza-container.md 5d259c4 
>   docs/learn/documentation/0.7.0/container/serialization.md f6570c9 
>   docs/learn/documentation/0.7.0/container/state-management.md 11a9f87 
>   docs/learn/documentation/0.7.0/container/streams.md 4e0f065 
>   docs/learn/documentation/0.7.0/container/windowing.md ebe2e86 
>   docs/learn/documentation/0.7.0/index.html f992f37 
>   docs/learn/documentation/0.7.0/introduction/architecture.md d451273 
>   docs/learn/documentation/0.7.0/introduction/background.md 87717e5 
>   docs/learn/documentation/0.7.0/introduction/concepts.md 76012e2 
>   docs/learn/documentation/0.7.0/jobs/configuration-table.html 8b42b3a 
>   docs/learn/documentation/0.7.0/jobs/configuration.md 3bb80ef 
>   docs/learn/documentation/0.7.0/jobs/job-runner.md b41a410 
>   docs/learn/documentation/0.7.0/jobs/logging.md 65a755c 
>   docs/learn/documentation/0.7.0/jobs/packaging.md 4f06625 
>   docs/learn/documentation/0.7.0/jobs/yarn-jobs.md 5dbbe54 
>   docs/learn/documentation/0.7.0/operations/kafka.md 8bb1a44 
>   docs/learn/documentation/0.7.0/operations/security.md 55a7f11 
>   docs/learn/documentation/0.7.0/yarn/application-master.md 92e1e18 
>   docs/learn/documentation/0.7.0/yarn/isolation.md 1a4f315 
>   docs/learn/tutorials/0.7.0/deploy-samza-job-from-hdfs.md ca5f599 
>   docs/learn/tutorials/0.7.0/index.md 5822cce 
>   docs/learn/tutorials/0.7.0/remote-debugging-samza.md e82e436 
>   docs/learn/tutorials/0.7.0/run-hello-samza-without-internet.md f7a0c1b 
>   docs/learn/tutorials/0.7.0/run-in-multi-node-yarn.md f47953a 
>   docs/sitemap.xml 7c7b269 
>   gradle.properties 3a3ee25 
>   gradle/buildscript.gradle aa29cc4 
>   gradle/dependency-versions-scala-2.10.gradle 2a3632d 
>   gradle/dependency-versions-scala-2.9.2.gradle 7ec296f 
>   gradle/dependency-versions.gradle e50ed40 
>   gradle/environment.gradle 07541c4 
>   gradle/license.gradle ca504e4 
>   gradle/maven.gradle fd54fad 
>   settings.gradle 9e7a4ea 
> 
> Diff: https://reviews.apache.org/r/22382/diff/
> 
> 
> Testing
> -------
> 
> Compiles, looked at web page output.
> 
> 
> Thanks,
> 
> Jakob Homan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message