samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raul Castro Fernandez" <r...@contxt.in>
Subject Re: Review Request 22335: Patch for samza-192
Date Tue, 10 Jun 2014 18:53:01 GMT


> On June 9, 2014, 10:37 p.m., Chris Riccomini wrote:
> > samza-core/src/main/scala/org/apache/samza/util/Util.scala, line 183
> > <https://reviews.apache.org/r/22335/diff/1/?file=605050#file605050line183>
> >
> >     Does this logic work for windows/linux/mac? Not sure this gives us any advantage
over just returning the raw getName results. True it's not a PID, but I think this might be
OK, and maybe a bit safer than doing the @ split, and potentially breaking platform support
for other random OS's that might format things differently.

Ok. I will then log the string. In this case, should we maintain the Util function, or just
read the property in SamzaContainer?


- Raul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22335/#review45162
-----------------------------------------------------------


On June 6, 2014, 11:44 p.m., Raul Castro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22335/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 11:44 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-192; container PID is logged in SamzaContainer. A new Util.getContainerPID function
returns the PID
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala bfff2a6 
>   samza-core/src/main/scala/org/apache/samza/util/Util.scala 1b548fd 
> 
> Diff: https://reviews.apache.org/r/22335/diff/
> 
> 
> Testing
> -------
> 
> I've tried the function in the debugger and the scala interpreter. Could not try it in
a different environemnt than Linux
> 
> 
> Thanks,
> 
> Raul Castro Fernandez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message