samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yan Fang" <yanfang...@gmail.com>
Subject Re: Review Request 22753: SAMZA-35. Everybody gets a javadoc!
Date Wed, 18 Jun 2014 21:33:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22753/#review46122
-----------------------------------------------------------


All the docs are great and very understandable for me. Nit: there are two typos. Thank you.


samza-api/src/main/java/org/apache/samza/metrics/MetricsRegistry.java
<https://reviews.apache.org/r/22753/#comment81316>

    It is a type? Crate -> Create?



samza-api/src/main/java/org/apache/samza/metrics/MetricsReporter.java
<https://reviews.apache.org/r/22753/#comment81320>

    Miss a "of" between interface and different? I am a little confused by this sentence.


- Yan Fang


On June 18, 2014, 8:32 p.m., Jakob Homan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22753/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 8:32 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> javadocs
> 
> 
> Diffs
> -----
> 
>   samza-api/src/main/java/org/apache/samza/Partition.java ebb77ed 
>   samza-api/src/main/java/org/apache/samza/checkpoint/Checkpoint.java dcf81bf 
>   samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointManager.java 34f50fd

>   samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointManagerFactory.java 5ce8f35

>   samza-api/src/main/java/org/apache/samza/config/Config.java c42c1c5 
>   samza-api/src/main/java/org/apache/samza/config/ConfigException.java b6ab549 
>   samza-api/src/main/java/org/apache/samza/config/ConfigFactory.java d6d7584 
>   samza-api/src/main/java/org/apache/samza/config/ConfigRewriter.java 7248e8b 
>   samza-api/src/main/java/org/apache/samza/config/MapConfig.java 337e921 
>   samza-api/src/main/java/org/apache/samza/container/SamzaContainerContext.java 5aa7a8f

>   samza-api/src/main/java/org/apache/samza/job/ApplicationStatus.java 49052af 
>   samza-api/src/main/java/org/apache/samza/job/CommandBuilder.java 5ec6433 
>   samza-api/src/main/java/org/apache/samza/job/StreamJob.java f519949 
>   samza-api/src/main/java/org/apache/samza/job/StreamJobFactory.java 4cdcc2c 
>   samza-api/src/main/java/org/apache/samza/metrics/Counter.java 0838df3 
>   samza-api/src/main/java/org/apache/samza/metrics/Gauge.java 3335c15 
>   samza-api/src/main/java/org/apache/samza/metrics/MetricsRegistry.java 9df1ef6 
>   samza-api/src/main/java/org/apache/samza/metrics/MetricsReporter.java d52dfa9 
>   samza-api/src/main/java/org/apache/samza/metrics/MetricsReporterFactory.java 19eb91c

>   samza-api/src/main/java/org/apache/samza/metrics/MetricsType.java e79d4e6 
>   samza-api/src/main/java/org/apache/samza/metrics/MetricsVisitor.java fee0883 
>   samza-api/src/main/java/org/apache/samza/metrics/ReadableMetricsRegistry.java ebea426

>   samza-api/src/main/java/org/apache/samza/serializers/Deserializer.java fe72223 
>   samza-api/src/main/java/org/apache/samza/serializers/Serde.java fab1055 
>   samza-api/src/main/java/org/apache/samza/serializers/SerdeFactory.java a41a922 
>   samza-api/src/main/java/org/apache/samza/serializers/Serializer.java 932e9a5 
>   samza-api/src/main/java/org/apache/samza/storage/StorageEngine.java 96dec9b 
>   samza-api/src/main/java/org/apache/samza/storage/StorageEngineFactory.java da57bf0

>   samza-api/src/main/java/org/apache/samza/system/OutgoingMessageEnvelope.java c8ef980

>   samza-api/src/main/java/org/apache/samza/system/SystemAdmin.java 3976253 
>   samza-api/src/main/java/org/apache/samza/system/SystemConsumer.java a92e301 
>   samza-api/src/main/java/org/apache/samza/system/SystemFactory.java ae33e8e 
>   samza-api/src/main/java/org/apache/samza/system/SystemProducer.java 8967f57 
>   samza-api/src/main/java/org/apache/samza/system/SystemStream.java 0265a2c 
>   samza-api/src/main/java/org/apache/samza/system/SystemStreamPartition.java 5173ebd

>   samza-api/src/main/java/org/apache/samza/system/SystemStreamPartitionIterator.java
62a5eb7 
>   samza-api/src/main/java/org/apache/samza/system/chooser/MessageChooser.java 6d2fa23

>   samza-api/src/main/java/org/apache/samza/system/chooser/MessageChooserFactory.java
6442db9 
>   samza-api/src/main/java/org/apache/samza/task/ClosableTask.java a93cca0 
>   samza-api/src/main/java/org/apache/samza/task/StreamTask.java 00d5efd 
>   samza-api/src/main/java/org/apache/samza/task/TaskContext.java 611507e 
>   samza-api/src/main/java/org/apache/samza/task/TaskCoordinator.java 5049b1b 
>   samza-api/src/main/java/org/apache/samza/task/TaskLifecycleListenerFactory.java 31f32bc

>   samza-api/src/main/java/org/apache/samza/task/WindowableTask.java 1f48eec 
>   samza-api/src/main/java/org/apache/samza/util/BlockingEnvelopeMap.java 7171088 
>   samza-api/src/main/java/org/apache/samza/util/Clock.java e1a77e6 
>   samza-api/src/main/java/org/apache/samza/util/NoOpMetricsRegistry.java 8bc0764 
>   samza-core/src/main/scala/org/apache/samza/system/chooser/BootstrappingChooser.scala
91c1813 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala
5fb7a20 
> 
> Diff: https://reviews.apache.org/r/22753/diff/
> 
> 
> Testing
> -------
> 
> read it.
> 
> 
> Thanks,
> 
> Jakob Homan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message