samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yan Fang" <yanfang...@gmail.com>
Subject Re: Review Request 22845: SAMZA-215: Better logging for interactive command-line tools
Date Thu, 26 Jun 2014 16:52:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22845/
-----------------------------------------------------------

(Updated June 26, 2014, 4:52 p.m.)


Review request for samza.


Changes
-------

1. changed from SAMZA_LOG4J_FILE to SAMZA_LOG4J_CONFIG
2. changed the log4j-default.xml to log4j-console.xml
3. changed the dependencies in gradle.build for samza-shell and added log4j-console.xml as
the log4j configuration for samza-shell. So now ./gradlew uses the same log4j configuration
as the deploy/samza/bin/

Thank you. 


Repository: samza


Description
-------

1. added an environment variable SAMZA_LOG4J_FILE in each script. and run-class.sh use that
variable for log4j configuration instead of directly pointing to the position of log4j.xml.
2. added log4j-default.xml, which append the logs to console. run-job, kill-yarn-job and checkpoint
scripts use this configuration. 
3. changed the build.gradle to contain the new log4j-default.xml 


Diffs (updated)
-----

  build.gradle f728330 
  samza-shell/src/main/bash/checkpoint-tool.sh 1a455df 
  samza-shell/src/main/bash/kill-yarn-job.sh 924aac6 
  samza-shell/src/main/bash/run-am.sh c202596 
  samza-shell/src/main/bash/run-class.sh cc341b7 
  samza-shell/src/main/bash/run-container.sh 72cee18 
  samza-shell/src/main/bash/run-job.sh 0605994 
  samza-shell/src/main/resources/log4j-console.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/22845/diff/


Testing
-------


Thanks,

Yan Fang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message