samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Chen" <dc...@linkedin.com>
Subject Review Request 25607: SAMZA-412: Use JUnit Assert assertions in tests
Date Sat, 13 Sep 2014 05:49:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25607/
-----------------------------------------------------------

Review request for samza.


Bugs: SAMZA-412
    https://issues.apache.org/jira/browse/SAMZA-412


Repository: samza


Description
-------

SAMZA-412: Use JUnit Assert assertions in tests.


Diffs
-----

  samza-api/src/test/java/org/apache/samza/config/TestConfig.java e7012963aaa0bd171dd5a588ec7c25c17273212a

  samza-api/src/test/java/org/apache/samza/metrics/TestSlidingTimeWindowReservoir.java eb5043b13a4b70f5805f9d6942e2a7d18f426ea9

  samza-api/src/test/java/org/apache/samza/metrics/TestTimer.java dcc3cb8df3c85ae4aa4057a33b77ebfd426cc078

  samza-api/src/test/java/org/apache/samza/util/TestBlockingEnvelopeMap.java 35ba52d3bab071b4dea3630bb6ebed3b406c44dd

  samza-api/src/test/java/org/apache/samza/util/TestNoOpMetricsRegistry.java 2d0034f56ac42de8cfc05103c5c806b698dae901

  samza-api/src/test/java/org/apache/samza/util/TestSinglePartitionWithoutOffsetsSystemAdmin.java
4166493bf82006efae10e9105822c370cc6106f2 
  samza-core/src/test/scala/org/apache/samza/checkpoint/TestCheckpointTool.scala 1eb3995416b8fa0ffd0ad50c60c0a95e2886397c

  samza-core/src/test/scala/org/apache/samza/checkpoint/TestOffsetManager.scala 44a98a533eccdce81a4db923b564f1f78e7b5e75

  samza-core/src/test/scala/org/apache/samza/config/factories/TestPropertiesConfigFactory.scala
f254741644e70966464f40240865b81670636270 
  samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 8a04a8ad734439e4b7de24f088fc3c064346ab34

  samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala be53373d143c2d504824ee1251f978ffefe31a33

  samza-core/src/test/scala/org/apache/samza/container/TestTaskNamesToSystemStreamPartitions.scala
d680b20020b7b857a4a34ce55b48bc88fceaf2c0 
  samza-core/src/test/scala/org/apache/samza/container/grouper/stream/GroupByTestBase.scala
47d716e8e43e7e2641cd258885467effb708c3ba 
  samza-core/src/test/scala/org/apache/samza/container/grouper/stream/TestGroupByPartition.scala
2fa718c4ddca173571f579ee1bf327749b071e91 
  samza-core/src/test/scala/org/apache/samza/container/grouper/stream/TestGroupBySystemStreamPartition.scala
8da0595e43c4cd47267fb4a67d5f90f669648c92 
  samza-core/src/test/scala/org/apache/samza/job/TestJobRunner.scala 258ccc137819358b90ae05d10e4ad92eedd46f8c

  samza-core/src/test/scala/org/apache/samza/job/TestShellCommandBuilder.scala f8a535add4a01a5f129fe98bc54078bf77a6ae1c

  samza-core/src/test/scala/org/apache/samza/job/local/TestProcessJob.scala d56024d89875920c634af7dc30650937ed9d0a35

  samza-core/src/test/scala/org/apache/samza/job/local/TestThreadJob.scala 7d45889d61b6d2fca4b63eeca856fdf1e4041bfc

  samza-core/src/test/scala/org/apache/samza/metrics/TestJmxServer.scala f01117dd6360e9830f5ba5054fedad7984f8c622

  samza-core/src/test/scala/org/apache/samza/metrics/reporter/TestJmxReporter.scala f6c8646fdc9bc1cbfec85cd581af43ca7487955e

  samza-core/src/test/scala/org/apache/samza/serializers/TestByteSerde.scala f64c2638b694dcd9ae9b8e5fe409e44c63c255e1

  samza-core/src/test/scala/org/apache/samza/serializers/TestCheckpointSerde.scala 0d07314a2607463cf199418b68c1ff0e7102e1ad

  samza-core/src/test/scala/org/apache/samza/serializers/TestIntegerSerde.scala 45a2b042ecd921c3cc054ecc717174ca30214dbc

  samza-core/src/test/scala/org/apache/samza/serializers/TestStringSerde.scala 7fbf0c2863b2b892faf974fb26672af970e08631

  samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala 04229a6770d100136a3a5947e27df8b22e3c2bc4

  samza-core/src/test/scala/org/apache/samza/system/chooser/TestBatchingChooser.scala d7632b4f3a5e5c4addb2d587dc430bdce7b3a678

  samza-core/src/test/scala/org/apache/samza/system/chooser/TestBootstrappingChooser.scala
993daa6bf6d8d70726350434ae8b06227502b4ff 
  samza-core/src/test/scala/org/apache/samza/system/chooser/TestDefaultChooser.scala 884e4587da0e66144cf3bcbe226fff0949f0d57f

  samza-core/src/test/scala/org/apache/samza/system/chooser/TestRoundRobinChooser.scala 01802b9c8d569dfbdd8db87ccef7ab63ed31f60a

  samza-core/src/test/scala/org/apache/samza/system/chooser/TestTieredPriorityChooser.scala
4cde630b94d8dce910bc9e43c5da94fde8a537f1 
  samza-core/src/test/scala/org/apache/samza/system/filereader/TestFileReaderSystemAdmin.scala
fb26bfcb2f4836defcf2210e2c187adbacaaf8bc 
  samza-core/src/test/scala/org/apache/samza/system/filereader/TestFileReaderSystemConsumer.scala
f505eb19dc11eb1c55220b1d0953befbd5121a5d 
  samza-core/src/test/scala/org/apache/samza/system/filereader/TestFileReaderSystemFactory.scala
330df78c1113c1fbf7858a0da9482c7b78b68b45 
  samza-core/src/test/scala/org/apache/samza/task/TestReadableCoordinator.scala 7cfeb5ae0d9ca3ecc07304ef4456517cc6b52548

  samza-core/src/test/scala/org/apache/samza/util/TestDaemonThreadFactory.scala 635337841bd5e5aa87c67e2531afaa93c61f77a9

  samza-core/src/test/scala/org/apache/samza/util/TestExponentialSleepStrategy.scala 4a561d14a52cd3b6c8aff0b6f7ddd7aea86e759a

  samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala 7c314ce985a95f3afbe6ac4c7f131626a8eca064

  samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointLogKey.scala
7a23041e9c9847ad225b7ecd2b9c6516cb74e247 
  samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala
4827731be01c41643ae091872d5b1edbf6591229 
  samza-kafka/src/test/scala/org/apache/samza/config/TestKafkaConfig.scala 468aa3d284243f2c96fa2fdd01a52408891768d0

  samza-kafka/src/test/scala/org/apache/samza/config/TestKafkaSerdeConfig.scala fabae68fc1ec67c6a9cf2d5f13bb99492bd5376b

  samza-kafka/src/test/scala/org/apache/samza/config/TestRegExTopicGenerator.scala 77cdbe3cd06798ce1a7dc184828daa2204c8bb1d

  samza-kafka/src/test/scala/org/apache/samza/serializers/TestKafkaSerde.scala f6fa6bb217f0daccb355c22344081ab55ad5fe57

  samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala 9143e6c32e88b6475bb60d5250b6215b33fd5f28

  samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestGetOffset.scala 6a9ebcade4face8ee44c8404d26f7d3d2ccae257

  samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemAdmin.scala be1670c7d4c3d6fae8d677f66eecedc10c7ad314

  samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemConsumer.scala 23e3e3547aee0a711b778cffb69c3f908bcca47e

  samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemFactory.scala aba39c0cf99b2ede6597d6dfa0f12cb187276c5b

  samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala 3684db545050af3d0afe0fab375f3a8992394d79

  samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestTopicMetadataCache.scala 9ddcb71322315bf169fd9fb7a51745261a8abe7c

  samza-kv-leveldb/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 1f09ae5b23d0451af286e88538d81fcd6bea769a

  samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestJmxAppender.java 036d80c9daa6018188c6afc02b2a2afd293f11d4

  samza-serializers/src/test/scala/org/apache/samza/serializers/TestJsonSerde.scala e2a153b98e33fb598e716d9533d05494c61e2a1b

  samza-serializers/src/test/scala/org/apache/samza/serializers/TestMetricsSnapshotSerde.scala
b307334fc18c81915e450ef175f0179548a8757e 
  samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala 44ab62302d15f87871e5d0f63172d97f72f3bb75

  samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala
1ff898d18096041be32a9468df4817d2bb0142ff 
  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMaster.scala 190ce28b29dc0405e3d4e3b6796b5fd002694525

  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala 3418a4c5644317868e431ee8b266ad20fcb99926

  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterService.scala d68dbdd5e568ec802bce258cad47bf31ab829813

  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala
8cfdbe0ef3da34567fa7c091273e2b90d5f35e69 

Diff: https://reviews.apache.org/r/25607/diff/


Testing
-------

All tests pass


Thanks,

David Chen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message